remove override in react agent #210
Merged
raghotham merged 1 commit intollamastack:mainfrom Mar 24, 2025
Merged
Conversation
raghotham
approved these changes
Mar 24, 2025
raghotham
requested changes
Mar 24, 2025
Member
raghotham
left a comment
There was a problem hiding this comment.
Can you add this instead of removing?
from typing import override
Contributor
Author
|
@raghotham @hardikjshah I am using python3.10 and got this error Traceback (most recent call last):
File "/Users/kaiwu/work/internal-llama-stack-apps/examples/computer_use/test_vision.py", line 5, in <module>
from llama_stack_client.lib.agents.react.agent import ReActAgent
File "/Users/kaiwu/work/to_merge/llama-stack-client-python/src/llama_stack_client/lib/agents/react/agent.py", line 20, in <module>
from .tool_parser import ReActOutput, ReActToolParser
File "/Users/kaiwu/work/to_merge/llama-stack-client-python/src/llama_stack_client/lib/agents/react/tool_parser.py", line 9, in <module>
from typing import List, Optional, Union, override
ImportError: cannot import name 'override' from 'typing' (/opt/homebrew/anaconda3/envs/dmg/lib/python3.10/typing.py) It seems that typing.override added in python 3.12, we have to remove it to support 3.10 or do we want to set minimal python version to 3.12 instead? |
raghotham
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Running into this error:
Removing this line fixed this error.
Now I can run react agent:
Test Plan
[Describe the tests you ran to verify your changes with result summaries. Provide clear instructions so the plan can be easily re-executed.]